Hi, Dennis:
On Wed, 2020-03-04 at 10:32 +0800, CK Hu wrote:
Hi, Dennis:
On Tue, 2020-03-03 at 18:58 +0800, Dennis YC Hsieh wrote:
Some gce hardware shift pc and end address in register to support large dram addressing. Implement gce address shift when write or read pc and end register. And add shift bit in platform definition.
Signed-off-by: Dennis YC Hsieh dennis-yc.hsieh@mediatek.com
drivers/mailbox/mtk-cmdq-mailbox.c | 61 ++++++++++++++++++------ drivers/soc/mediatek/mtk-cmdq-helper.c | 3 +- include/linux/mailbox/mtk-cmdq-mailbox.h | 2 + 3 files changed, 50 insertions(+), 16 deletions(-)
[snip]
diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c index de20e6cba83b..2e1bc513569b 100644 --- a/drivers/soc/mediatek/mtk-cmdq-helper.c +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c @@ -291,7 +291,8 @@ static int cmdq_pkt_finalize(struct cmdq_pkt *pkt)
/* JUMP to end */ inst.op = CMDQ_CODE_JUMP;
- inst.value = CMDQ_JUMP_PASS;
- inst.value = CMDQ_JUMP_PASS >>
cmdq_mbox_shift(((struct cmdq_client *)pkt->cl)->chan);Why not just cmdq_mbox_shift(pkt->cl->chan) ?
Sorry, the type of pkt->cl is 'void *', so you need to cast it.
Reviewed-by: CK Hu ck.hu@mediatek.com
Regards, CK
err = cmdq_pkt_append_command(pkt, inst);
return err; diff --git a/include/linux/mailbox/mtk-cmdq-mailbox.h b/include/linux/mailbox/mtk-cmdq-mailbox.h index a4dc45fbec0a..dfe5b2eb85cc 100644 --- a/include/linux/mailbox/mtk-cmdq-mailbox.h +++ b/include/linux/mailbox/mtk-cmdq-mailbox.h @@ -88,4 +88,6 @@ struct cmdq_pkt { void *cl; };
+u8 cmdq_mbox_shift(struct mbox_chan *chan);
#endif /* __MTK_CMDQ_MAILBOX_H__ */