Re: [PATCH 3/9] drm/vc4: Add create and map BO ioctls.

On 08.12.2015 10:16, Eric Anholt wrote:

Emil Velikov emil.l.velikov@gmail.com writes:

...

Hi Eric,

A couple of suggestions/requests on the UAPI header side

On 1 December 2015 at 20:35, Eric Anholt eric@anholt.net wrote:

...

--- /dev/null +++ b/include/uapi/drm/vc4_drm.h

...

+#include <drm/drm.h>

Can we make this a "drm.h" ?

Nope.

include/uapi/drm/vc4_drm.h:27:17: fatal error: drm.h: No such file or directory

What happened to include/uapi/drm/drm.h in that tree?

and none of the drivers do, either.

daenzer@kaveri|11:55:31> grep '#include "drm.h"' include/uapi/drm/* include/uapi/drm/amdgpu_drm.h:#include "drm.h" include/uapi/drm/radeon_drm.h:#include "drm.h"

Patches to convert the rest are pending.