Hi Nicolas, On Tue, Jul 27, 2021 at 09:45:21AM +0800, Nicolas Boichat wrote:
Many of the DSI flags have names opposite to their actual effects, e.g. MIPI_DSI_MODE_EOT_PACKET means that EoT packets will actually be disabled. Fix this by including _NO_ in the flag names, e.g. MIPI_DSI_MODE_NO_EOT_PACKET.
Signed-off-by: Nicolas Boichat drinkcat@chromium.org Reviewed-by: Linus Walleij linus.walleij@linaro.org Reviewed-by: Robert Foss robert.foss@linaro.org Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com Reviewed-by: Andrzej Hajda andrzej.hajda@samsung.com Reviewed-by: Xin Ji xji@analogixsemi.com # anx7625.c Reviewed-by: Abhinav Kumar abhinavk@codeaurora.org # msm/dsi
I considered adding _DISABLE_ instead, but that'd make the flag names a big too long.
Generated with: flag=MIPI_DSI_MODE_VIDEO_HFP; git grep $flag | cut -f1 -d':' | \ xargs -I{} sed -i -e "s/$flag/MIPI_DSI_MODE_VIDEO_NO_HFP/" {} flag=MIPI_DSI_MODE_VIDEO_HBP; git grep $flag | cut -f1 -d':' | \ xargs -I{} sed -i -e "s/$flag/MIPI_DSI_MODE_VIDEO_NO_HBP/" {} flag=MIPI_DSI_MODE_VIDEO_HSA; git grep $flag | cut -f1 -d':' | \ xargs -I{} sed -i -e "s/$flag/MIPI_DSI_MODE_VIDEO_NO_HSA/" {} flag=MIPI_DSI_MODE_EOT_PACKET; git grep $flag | cut -f1 -d':' | \ xargs -I{} sed -i -e "s/$flag/MIPI_DSI_MODE_NO_EOT_PACKET/" {} (then minor format changes)
Changes in v3:
- Added all R-b tags from v1 and v2 (hopefully didn't miss any).
Changes in v2:
- Rebased on latest linux-next, after some of the flags got fixed (Linus Walleij).
Thanks for the update, applied to drm-misc-next.
Sam