On 06/28/17 08:38, Arvind Yadav wrote:
of_device_ids are not supposed to change at runtime. All functions working with of_device_ids provided by <linux/of.h> work with const of_device_ids. So mark the non-const structs as const.
File size before: text data bss dec hex filename 1531 592 0 2123 84b drivers/gpu/drm/tilcdc/tilcdc_panel.o
File size after constify: text data bss dec hex filename 1915 176 0 2091 82b drivers/gpu/drm/tilcdc/tilcdc_panel.o
Signed-off-by: Arvind Yadav arvind.yadav.cs@gmail.com
Thanks, I pick this up and push it in next merge window (for 4.14). However, both this and the bundled tfp410 driver is going away as soon as I have time to do it, but it is unlikely to happen before v4.14.
Best regards, Jyri
Changes in v1: Subject was not correct.
drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c index 28c3e2f..2abe7c4 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c @@ -419,7 +419,7 @@ static int panel_remove(struct platform_device *pdev) return 0; }
-static struct of_device_id panel_of_match[] = { +static const struct of_device_id panel_of_match[] = { { .compatible = "ti,tilcdc,panel", }, { }, };