Re: [v3 1/7] drm/mediatek: move mipi_dsi_host_register to probe

On Sun, May 19, 2019 at 9:25 AM Jitao Shi jitao.shi@mediatek.com wrote:

@@ -1045,12 +1045,6 @@ static int mtk_dsi_bind(struct device *dev, struct device *master, void *data) return ret; }

•   ret = mipi_dsi_host_register(&dsi->host);
  

•   if (ret < 0) {
  

•           dev_err(dev, "failed to register DSI host: %d\n", ret);
  

•           goto err_ddp_comp_unregister;
  

•   }
  

•   ret = mtk_dsi_create_conn_enc(drm, dsi);
    if (ret) {
            DRM_ERROR("Encoder create failed with %d\n", ret);
  

@@ -1060,8 +1054,6 @@ static int mtk_dsi_bind(struct device *dev, struct device *master, void *data) return 0;

err_unregister:

•   mipi_dsi_host_unregister(&dsi->host);
  

-err_ddp_comp_unregister: mtk_ddp_comp_unregister(drm, &dsi->ddp_comp); return ret; } @@ -1097,31 +1089,37 @@ static int mtk_dsi_probe(struct platform_device *pdev)

    dsi->host.ops = &mtk_dsi_ops;
    dsi->host.dev = dev;

•   dsi->dev = dev;
  

•   ret = mipi_dsi_host_register(&dsi->host);
  

•   if (ret < 0) {
  

•           dev_err(dev, "failed to register DSI host: %d\n", ret);
  

•           return ret;
  

•   }
  
  

Since mipi_dsi_host_register() is moved from .bind to .probe, mipi_dsi_host_unregister() should also be moved from .unbind to .remove?

Thanks