On Mon, Feb 24, 2020 at 5:10 PM Alex Deucher alexdeucher@gmail.com wrote:
On Sat, Feb 22, 2020 at 12:54 PM Daniel Vetter daniel.vetter@ffwll.ch wrote:
This doesn't do anything except auto-init drm_agp support when you call drm_get_pci_dev(). Which amdgpu stopped doing with
commit b58c11314a1706bf094c489ef5cb28f76478c704 Author: Alex Deucher alexander.deucher@amd.com Date: Fri Jun 2 17:16:31 2017 -0400
drm/amdgpu: drop deprecated drm_get_pci_dev and drm_put_devNo idea whether this was intentional or accidental breakage, but I guess anyone who manages to boot a this modern gpu behind an agp bridge deserves a price. A price I never expect anyone to ever collect :-)
Cc: Alex Deucher alexander.deucher@amd.com Cc: "Christian König" christian.koenig@amd.com Cc: Hawking Zhang Hawking.Zhang@amd.com Cc: Xiaojie Yuan xiaojie.yuan@amd.com Cc: Evan Quan evan.quan@amd.com Cc: "Tianci.Yin" tianci.yin@amd.com Cc: "Marek Olšák" marek.olsak@amd.com Cc: Hans de Goede hdegoede@redhat.com Signed-off-by: Daniel Vetter daniel.vetter@intel.com
Series is: Reviewed-by: Alex Deucher alexander.deucher@amd.com I'm happy to take the patches through my tree or drm-misc.
I don't have anything building on top of this, just random things from my tree. Reason I sent it out is Laurent's series to make a const drm_driver possible, but I don't think they'll conflict. So amd trees for the series is perfectly fine and probably simplest. -Daniel
Alex
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 4598836c5fa4..6cea92017109 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c @@ -1379,7 +1379,7 @@ int amdgpu_file_to_fpriv(struct file *filp, struct amdgpu_fpriv **fpriv)
static struct drm_driver kms_driver = { .driver_features =
DRIVER_USE_AGP | DRIVER_ATOMIC |
DRIVER_ATOMIC | DRIVER_GEM | DRIVER_RENDER | DRIVER_MODESET | DRIVER_SYNCOBJ | DRIVER_SYNCOBJ_TIMELINE,-- 2.24.1
dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel