1. Currently conn_state->crtc is getting assigned a value at two places We can just reduce this assignment to one
Signed-off-by: Satendra Singh Thakur satendra.t@samsung.com --- v1: Hi Mr Maarten, Thanks for the comments. I have modified the patch suitably. Please review.
drivers/gpu/drm/drm_atomic.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 895741e..560b01c 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -1559,7 +1559,6 @@ drm_atomic_set_crtc_for_connector(struct drm_connector_state *conn_state, ~(1 << drm_connector_index(conn_state->connector));
drm_connector_put(conn_state->connector); - conn_state->crtc = NULL; }
if (crtc) { @@ -1571,7 +1570,6 @@ drm_atomic_set_crtc_for_connector(struct drm_connector_state *conn_state, 1 << drm_connector_index(conn_state->connector);
drm_connector_get(conn_state->connector); - conn_state->crtc = crtc;
DRM_DEBUG_ATOMIC("Link connector state %p to [CRTC:%d:%s]\n", conn_state, crtc->base.id, crtc->name); @@ -1579,6 +1577,7 @@ drm_atomic_set_crtc_for_connector(struct drm_connector_state *conn_state, DRM_DEBUG_ATOMIC("Link connector state %p to [NOCRTC]\n", conn_state); } + conn_state->crtc = crtc;
return 0; }