Re: [PATCH 01/16] drm: fixes crct set_mode when crtc mode_fixup is null.

Hello.

On 02/16/2016 05:10 PM, Carlos Palminha wrote:

This patch set nukes all the dummy crtc mode_fixup implementations. (made on top of Daniel topic/drm-misc branch)

Signed-off-by: Carlos Palminha palminha@synopsys.com

drivers/gpu/drm/drm_crtc_helper.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c index e70d064..7539eea 100644 --- a/drivers/gpu/drm/drm_crtc_helper.c +++ b/drivers/gpu/drm/drm_crtc_helper.c @@ -343,9 +343,12 @@ bool drm_crtc_helper_set_mode(struct drm_crtc *crtc, } }

• if (!(ret = crtc_funcs->mode_fixup(crtc, mode, adjusted_mode))) {

• DRM_DEBUG_KMS("CRTC fixup failed\n");
  

• goto done;
  

• if (crtc_funcs->mode_fixup) {

• if (!(ret = crtc_funcs->mode_fixup(crtc, mode,
  

• 				adjusted_mode))) {
  

You haven't run the patch thru scripts/checkpatch.pl, have you? :-) (It curses on assignment inside the *if* expression.)

[...]

MBR, Sergei