On Thu, Jul 28, 2016 at 05:40:31PM +0200, Lukas Wunner wrote:
On Thu, Jul 28, 2016 at 03:33:25PM +0000, Deucher, Alexander wrote:
From: Peter Wu [mailto:peter@lekensteyn.nl] Sent: Thursday, July 21, 2016 6:43 AM In case you missed it, Dave's D3cold patches were succeeded by changes in PCI core. Relevant commits in the pci/pm branch:
006d44e PCI: Add runtime PM support for PCIe ports 16468c7 ACPI / hotplug / PCI: Runtime resume bridge before rescan d963f65 PCI: Power on bridges before scanning new devices 9d26d3a PCI: Put PCIe ports into D3 during suspend 43f7f88 PCI: Don't clear d3cold_allowed for PCIe portsDid those get merged yet?
They will go into 4.8. Should have gone into 4.7 already but were dropped at the last minute.
I just need to revert this commit once the d3cold patches land: https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.8&id=bdfb...
So you probably need to revert this now.
Best regards, Lukas
It is better to revert it before the PCI/PM patches get merged, otherwise you risk that the device is already put in D3 before the bridge tries to do it again. This is currently happening with nouveau on -next.
Do these AMD hw exist on BIOSes pre-2015? Currently the D3cold work in the PCI/PM branch only enable the D3cold handling via the bridge when the BIOS is >= 2015.