Re: [PATCH v2 05/15] drm/armada: Use drm_fb_helper_lastclose() and _poll_changed()

On Mon, Oct 30, 2017 at 04:39:41PM +0100, Noralf Trønnes wrote:

-static void armada_output_poll_changed(struct drm_device *dev) -{

• struct armada_private *priv = dev->dev_private;
• struct drm_fb_helper *fbh = priv->fbdev;
• if (fbh)

• drm_fb_helper_hotplug_event(fbh);
  

-}

const struct drm_mode_config_funcs armada_drm_mode_config_funcs = { .fb_create = armada_fb_create,

• .output_poll_changed = armada_output_poll_changed,

• .output_poll_changed = drm_fb_helper_output_poll_changed,

I think this is fine, because although it gets rid of the NULL checks for the drm_fb_helper structure, the driver will fail to initialise unless priv->fbdev and the fb helper successfully initialises.

It would be nice to mention that in the commit message as to why removing those NULL checks is safe.

In any case,

Acked-by: Russell King rmk+kernel@armlinux.org.uk

Thanks.