On 2019-10-25 6:18 p.m., Will Deacon wrote:
On Fri, Oct 25, 2019 at 06:06:26PM +0200, Michel Dänzer wrote:
On 2019-10-25 1:04 p.m., Will Deacon wrote:
In the highly unlikely event that we fail to allocate the "radeon-crtc" workqueue, we should bail cleanly rather than blindly march on with a NULL pointer installed for the 'flip_queue' field of the 'radeon_crtc' structure.
This was reported previously by Nicolas, but I don't think his fix was correct:
Neither is this one I'm afraid. See my feedback on https://patchwork.freedesktop.org/patch/331534/ .
Thanks. Although I agree with you wrt the original patch, I don't think the workqueue allocation failure is distinguishable from the CRTC allocation failure with my patch. Are you saying that the error path there is broken too?
The driver won't actually work if radeon_crtc_init bails silently, it'll just fall over at some later point.