On Mon, Jul 01, 2013 at 07:28:49PM +0900, Seung-Woo Kim wrote:
Hello Chris,
Thank you for reviewing.
On 2013년 07월 01일 19:23, Chris Wilson wrote:
On Mon, Jul 01, 2013 at 07:06:31PM +0900, Seung-Woo Kim wrote:
seq of a trace point is unsigned int but print format was %d. So it fixes the format as %u even the format can be not used.
I don't understand what you mean here. The patch itself looks fine.
I can not find where the format is used or not, so I think the format is not really used anywhere. If you want to fix the commit-msg, I'll update and re-send this patch.
One of the tricks performed by the TRACE() macro is that it prepends "trace_" to the name of the tracepoint for use in the code.
git grep trace_drm_vblank_event: drivers/gpu/drm/drm_irq.c: trace_drm_vblank_event_delivered(e->base.pid, e->pipe, drivers/gpu/drm/drm_irq.c: trace_drm_vblank_event_queued(current->pid, pipe, drivers/gpu/drm/drm_irq.c: trace_drm_vblank_event(crtc, seq); -Chris