Re: [PATCH v6 1/5] dt-bindings:drm/bridge:anx7625:add vendor define flags

Hi Xin,

Thank you for the patch.

On Fri, Mar 19, 2021 at 02:32:39PM +0800, Xin Ji wrote:

Add 'bus-type' and 'data-lanes' define for port0. Define DP tx lane0, lane1 swing register array define, and audio enable flag.

Signed-off-by: Xin Ji xji@analogixsemi.com

.../display/bridge/analogix,anx7625.yaml | 58 ++++++++++++++++++- 1 file changed, 57 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml index c789784efe30..3f54d5876982 100644 --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml @@ -34,6 +34,26 @@ properties: description: used for reset chip control, RESET_N pin B7. maxItems: 1

• analogix,lane0-swing:
• $ref: /schemas/types.yaml#/definitions/uint32-array
• minItems: 1
• maxItems: 20
• description:

•  an array of swing register setting for DP tx lane0 PHY, please don't
  

•  add this property, or contact vendor.
  

DT properties need to be documented. Contacting the vendor doesn't count as documentation I'm afraid.

• analogix,lane1-swing:
• $ref: /schemas/types.yaml#/definitions/uint32-array
• minItems: 1
• maxItems: 20
• description:

•  an array of swing register setting for DP tx lane1 PHY, please don't
  

•  add this property, or contact vendor.
  

• analogix,audio-enable:
• type: boolean
• description: let the driver enable audio HDMI codec function or not.
• ports: $ref: /schemas/graph.yaml#/properties/ports

@@ -41,13 +61,43 @@ properties: port@0: $ref: /schemas/graph.yaml#/properties/port description:

•      Video port for MIPI DSI input.
  

•      MIPI DSI/DPI input.
  

•    properties:
  

•      endpoint:
  

•        $ref: /schemas/media/video-interfaces.yaml#
  

•        type: object
  

•        additionalProperties: false
  

•        properties:
  

•          remote-endpoint: true
  

•          bus-type: true
  

•          data-lanes: true
  

•        required:
  

•          - remote-endpoint
  

•    required:
  

•      - endpoint
  

•  port@1:
     $ref: /schemas/graph.yaml#/properties/port
     description:
       Video port for panel or connector.
  
  

•    properties:
  

•      endpoint:
  

•        $ref: /schemas/media/video-interfaces.yaml#
  

•        type: object
  

•        additionalProperties: false
  

•        properties:
  

•          remote-endpoint: true
  

•        required:
  

•          - remote-endpoint
  

• required: - port@0 - port@1

@@ -73,6 +123,10 @@ examples: enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>;

•        analogix,audio-enable;
  

•        analogix,lane0-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>;
  

•        analogix,lane1-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>;
  

•        ports {
             #address-cells = <1>;
             #size-cells = <0>;
  

@@ -81,6 +135,8 @@ examples: reg = <0>; anx7625_in: endpoint { remote-endpoint = <&mipi_dsi>;

•                    bus-type = <5>;
  

•                    data-lanes = <0 1 2 3>;
                 };
             };