On Fri, Jan 28, 2022 at 06:58:29PM +0100, Uwe Kleine-König wrote:
Hello Rob,
On Fri, Jan 28, 2022 at 07:04:10AM -0600, Rob Herring wrote:
On Fri, Jan 28, 2022 at 4:59 AM Uwe Kleine-König u.kleine-koenig@pengutronix.de wrote:
From: Marian Cichy m.cichy@pengutronix.de
This files documents the device tree for the new imx21-lcdc DRM driver.
No, bindings document h/w and the h/w has not changed. We already have a binding for the LCDC.
Just to be sure we're talking about the same thing: You're refering to Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt, right?
Looks right...
I'm unsure what to do now. Should the two different bindings just be described in the same file? Should I stick to fsl,imx21-fb even for the new binding? (The hardware unit is named LCDC, so the name chosen here is the better one.) Please advise.
Yes, the name is unfortunate, but it should be 1 binding, 1 file, and unchanged (unless you want to add new optional properties).
Rob