On Fri 20 May 09:26 PDT 2022, Kuogee Hsieh wrote:
This patch add regulator_set_load() before enable regulator at eDP phy driver.
Signed-off-by: Kuogee Hsieh quic_khsieh@quicinc.com
drivers/phy/qualcomm/phy-qcom-edp.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c index cacd32f..afd9e17 100644 --- a/drivers/phy/qualcomm/phy-qcom-edp.c +++ b/drivers/phy/qualcomm/phy-qcom-edp.c @@ -87,12 +87,17 @@ struct qcom_edp {
struct clk_bulk_data clks[2]; struct regulator_bulk_data supplies[2];
- int enable_load[2];
};
static int qcom_edp_phy_init(struct phy *phy) { struct qcom_edp *edp = phy_get_drvdata(phy); int ret;
- int i;
- for (i = 0; i < ARRAY_SIZE(edp->supplies); i++)
regulator_set_load(edp->supplies[i].consumer, edp->enable_load[i]);
The regulator framework only accounts for the load of enabled regulator consumers, so you should be able to just call regulator_set_load() right after devm_regulator_bulk_get() and not carry the enable_load array of static constants.
Regards, Bjorn
ret = regulator_bulk_enable(ARRAY_SIZE(edp->supplies), edp->supplies); if (ret) @@ -635,6 +640,8 @@ static int qcom_edp_phy_probe(struct platform_device *pdev)
edp->supplies[0].supply = "vdda-phy"; edp->supplies[1].supply = "vdda-pll";
- edp->enable_load[0] = 21800; /* load for 1.2 V vdda-phy supply */
- edp->enable_load[1] = 36000; /* load for 0.9 V vdda-pll supply */ ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(edp->supplies), edp->supplies); if (ret) return ret;
-- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project