Re: [PATCH] drm/amd/display: remove unused function dc_link_perform_link_training

Applied. Thanks!

Alex

On Sun, May 9, 2021 at 11:42 AM Rouven Czerwinski rouven@czerwinskis.de wrote:

This function is not used anywhere, remove it. It was added in 40dd6bd376a4 ("drm/amd/display: Linux Set/Read link rate and lane count through debugfs") and moved in fe798de53a7a ("drm/amd/display: Move link functions from dc to dc_link"), but a user is missing.

Signed-off-by: Rouven Czerwinski r.czerwinski@pengutronix.de

drivers/gpu/drm/amd/display/dc/core/dc_link.c | 13 ------------- drivers/gpu/drm/amd/display/dc/dc_link.h | 3 --- 2 files changed, 16 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c index 3fb0cebd6938..55c5cf2264b3 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c @@ -3553,19 +3553,6 @@ void dc_link_set_drive_settings(struct dc *dc, dc_link_dp_set_drive_settings(dc->links[i], lt_settings); }

-void dc_link_perform_link_training(struct dc *dc,

•                              struct dc_link_settings *link_setting,
  

•                              bool skip_video_pattern)
  

-{

•   int i;
  

•   for (i = 0; i < dc->link_count; i++)
  

•           dc_link_dp_perform_link_training(
  

•                   dc->links[i],
  

•                   link_setting,
  

•                   skip_video_pattern);
  

-}

void dc_link_set_preferred_link_settings(struct dc *dc, struct dc_link_settings *link_setting, struct dc_link *link) diff --git a/drivers/gpu/drm/amd/display/dc/dc_link.h b/drivers/gpu/drm/amd/display/dc/dc_link.h index fc5622ffec3d..45c927cd27ab 100644 --- a/drivers/gpu/drm/amd/display/dc/dc_link.h +++ b/drivers/gpu/drm/amd/display/dc/dc_link.h @@ -363,9 +363,6 @@ bool dc_link_is_hdcp22(struct dc_link *link, enum signal_type signal); void dc_link_set_drive_settings(struct dc *dc, struct link_training_settings *lt_settings, const struct dc_link *link); -void dc_link_perform_link_training(struct dc *dc,

•                              struct dc_link_settings *link_setting,
  

•                              bool skip_video_pattern);
  

void dc_link_set_preferred_link_settings(struct dc *dc, struct dc_link_settings *link_setting, struct dc_link *link); -- 2.31.1

---

amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx