Re: [PATCH] drm/vc4: simplify exit path of a failed allocation of dsi_connector

Colin King colin.king@canonical.com writes:

From: Colin Ian King colin.king@canonical.com

If dsi_connector fails to allocate, the exit path via label 'fail' checks if connector is null, which it always is, so the cleanup that destroys connector is never going to be called. Hence the failure path can be more optimally performed by removing this and just returning ERR_PTR(-ENOMEM). This also removes the need to initialize connector to NULL, and we can also remove ret too.

Detected by CoverityScan, CID#1399504 ("Logicall Dead Code")

Signed-off-by: Colin Ian King colin.king@canonical.com

Reviewed and pushed to drm-misc-next. Thanks!