19 Jan
2021
19 Jan
'21
4:36 p.m.
On 1/19/21 2:34 AM, Greg KH wrote:
On Mon, Jan 18, 2021 at 04:01:19PM -0500, Andrey Grodzovsky wrote:
static struct pci_driver amdgpu_kms_pci_driver = { .name = DRIVER_NAME, .id_table = pciidlist, @@ -1595,6 +1607,7 @@ static struct pci_driver amdgpu_kms_pci_driver = { .shutdown = amdgpu_pci_shutdown, .driver.pm = &amdgpu_pm_ops, .err_handler = &amdgpu_pci_err_handler,
- .driver.dev_groups = amdgpu_sysfs_groups,
Shouldn't this just be: groups - amdgpu_sysfs_groups,
Why go to the "driver root" here?
Because I still didn't get to your suggestion to propose a patch to add groups to pci_driver, it's located in 'base' driver struct.
Andrey
Other than that tiny thing, looks good to me, nice cleanup!
greg k-h