Dne ponedeljek, 18. junij 2018 ob 14:58:02 CEST je Jagan Teki napisal(a):
On Thu, Jun 14, 2018 at 10:59 PM, Jernej Škrabec
jernej.skrabec@siol.net wrote:
Dne četrtek, 14. junij 2018 ob 19:16:46 CEST je Jagan Teki napisal(a):
On Thu, Jun 14, 2018 at 8:04 PM, Jernej Škrabec jernej.skrabec@siol.net
wrote:
Dne četrtek, 14. junij 2018 ob 09:12:41 CEST je Jagan Teki napisal(a):
On Wed, Jun 13, 2018 at 1:30 AM, Jernej Skrabec jernej.skrabec@siol.net
wrote:
This series adds support for R40 HDMI pipeline. It is a bit special than other already supported pipelines because it has additional unit called TCON TOP responsible for relationship configuration between mixers, TCONs and HDMI. Additionally, it has additional gates for DSI and TV TCONs, TV encoder clock settings and pin muxing between LCD and TV encoders.
However, it seems that TCON TOP will become a norm, since newer Allwinner SoCs like H6 also have this unit.
I tested different possible configurations:
- mixer0 <> TCON-TV0 <> HDMI
- mixer0 <> TCON-TV1 <> HDMI
- mixer1 <> TCON-TV0 <> HDMI
- mixer1 <> TCON-TV1 <> HDMI
Please review.
Best regards, Jernej
Changes from v1:
- Split DT bindings patch and updated description
- Split HDMI PHY patch
- Move header file from TCON TOP patch to dt bindings patch
- Added Rob reviewed-by tag
- Used clk_hw_register_gate() instead of custom gate registration
code
- Reworked TCON TOP to be part of of-graph. Because of that, a lot
of
new patches were added.
- Droped mixer index quirk patch
- Reworked TCON support for TCON TOP
- Updated commit messages
Jernej Skrabec (27): clk: sunxi-ng: r40: Add minimal rate for video PLLs clk: sunxi-ng: r40: Allow setting parent rate to display related
clocksclk: sunxi-ng: r40: Export video PLLs dt-bindings: display: sunxi-drm: Add TCON TOP description drm/sun4i: Add TCON TOP driver drm/sun4i: Fix releasing node when enumerating enpoints drm/sun4i: Split out code for enumerating endpoints in output port drm/sun4i: Add support for traversing graph with TCON TOP drm/sun4i: Don't skip TCONs if they don't have channel 0 dt-bindings: display: sun4i-drm: Add R40 TV TCON description drm/sun4i: tcon: Add support for tcon-top gate drm/sun4i: tcon: Generalize engine search algorithm drm/sun4i: Don't check for LVDS and RGB when TCON has only ch1 drm/sun4i: Don't check for panel or bridge on TV TCONs drm/sun4i: Add support for R40 TV TCON dt-bindings: display: sun4i-drm: Add R40 mixer compatibles drm/sun4i: Add support for R40 mixers dt-bindings: display: sun4i-drm: Add description of A64 HDMI PHY drm/sun4i: Enable DW HDMI PHY clock drm/sun4i: Don't change clock bits in DW HDMI PHY driver drm/sun4i: DW HDMI PHY: Add support for second PLL drm/sun4i: Add support for second clock parent to DW HDMI PHY clk
driverdrm/sun4i: Add support for A64 HDMI PHY drm: of: Export drm_crtc_port_mask() drm/sun4i: DW HDMI: Expand algorithm for possible crtcs ARM: dts: sun8i: r40: Add HDMI pipeline ARM: dts: sun8i: r40: Enable HDMI output on BananaPi M2 Ultra
Tested whole series on top of linux-next.
Tested-by: Jagan Teki jagan@amarulasolutions.com
Thanks!
I've V40 board, which is same as R40. I'm able to detect the HDMI but seems edid not detecting properly.
[ 0.983007] sun4i-drm display-engine: bound 1100000.mixer (ops 0xc074a80c) [ 0.999043] sun4i-drm display-engine: bound 1200000.mixer (ops 0xc074a80c) [ 1.006229] sun4i-drm display-engine: bound 1c70000.tcon-top (ops 0xc074e2ac) [ 1.013609] sun4i-drm display-engine: bound 1c73000.lcd-controller (ops 0xc0747a28) [ 1.053988] sun8i-dw-hdmi 1ee0000.hdmi: Detected HDMI TX controller v1.32a with HDCP (sun8i_dw_hdmi_phy) [ 1.063913] sun8i-dw-hdmi 1ee0000.hdmi: registered DesignWare HDMI I2C bus driver [ 1.071683] sun4i-drm display-engine: bound 1ee0000.hdmi (ops 0xc074a298) [ 1.078484] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). [ 1.085098] [drm] No driver support for vblank timestamp query. [ 1.091055] [drm] Cannot find any crtc or sizes [ 1.095995] [drm] Initialized sun4i-drm 1.0.0 20150629 for display-engine on minor 0
This seems like DT issue. Can you post somewhere your V40 DTSI (if it is different to R40) and board DTS?
same dtsi shared between r40 and v40, here is board dts support for HDMI[1]
This patch looks like exactly the same as mine for BananaPi M2U, so there should be no issues.
What about VCC-HDMI? Is powered? Can you measure it to check?
Best regards, Jernej