On 12/05/2022 04:41, Stephen Boyd wrote:
Quoting Dmitry Baryshkov (2022-05-11 18:30:55)
On 12/05/2022 04:29, Stephen Boyd wrote:
Quoting Dmitry Baryshkov (2022-05-11 18:01:31)
On Thu, 12 May 2022 at 03:54, Stephen Boyd swboyd@chromium.org wrote:
Quoting Dmitry Baryshkov (2022-05-06 18:00:20)
Does this supersede commit 01013ba9bbdd ("drm/msm/disp/dpu1: avoid clearing hw interrupts if hw_intr is null during drm uninit")? I mean that with this patch applied kms->irq_requested makes the check in dpu_core_irq_uninstall() irrelevant because it isn't called anymore?
Yes.
I didn't see it deleted in the second patch so is a revert going to be sent?
No need to. They are separate checks. The older one is superseded (as it will be never hit), but it is still valid and useful (to protect from the crash if this code changes again).
Ew, gross. The extra conditionals everywhere really makes it hard to follow along.
With the second patch being dropped I'd prefer to leave both conditions in place.