Hi,
On Fri, 11 Jun 2021 at 10:07, John Stultz john.stultz@linaro.org wrote:
On Wed, Mar 31, 2021 at 3:58 AM Dmitry Baryshkov dmitry.baryshkov@linaro.org wrote:
The 7nm, 10nm and 14nm drivers would store interim data used during VCO/PLL rate setting in the global dsi_pll_Nnm structure. Move this data structures to the onstack storage. While we are at it, drop unused/static 'config' data, unused config fields, etc.
Signed-off-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org Reviewed-by: Abhinav Kumar abhinavk@codeaurora.org Tested-by: Stephen Boyd swboyd@chromium.org # on sc7180 lazor
Hey Dmitry, Just wanted to give you a heads up. Peter Collingbourne reported today that his db845c wasn't booting to display for him on his 4k monitor. It works fine on a 1080p screen, and while 4k isn't supported (yet?), normally the board should fall back to 1080p when connected to a 4k monitor. I was able to reproduce this myself and I see the errors below[1].
It looks like I made a mistake testing these patches with the splash screen disabled. Stephen Boyd has proposed a fix few days ago (will be included into the 5.13). Could you check that it fixes the problem for you?
https://lore.kernel.org/linux-arm-msm/20210608195519.125561-1-swboyd@chromiu...
I dug back and found that things were working ok on v5.12 w/ the recently merged commit d1a97648ae028 ("drm/bridge: lt9611: Fix handling of 4k panels"), and started digging around.
Seeing a bunch of changes to the drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c file, I tried reverting a chunk of the changes since 5.12 to that, and that got it working again. I've narrowed it down to this change - 001d8dc33875 ("drm/msm/dsi: remove temp data from global pll structure") upstream (also reverting following 6e2ad9c3bfca and 36c5dde5fdf0 first - but its reverting this change that actually makes it work again).
I've not managed to really look into the change to see what might be going wrong yet (its late and I'm about to crash), but I wanted to give you a heads up. If you have any ideas for me to try I'm happy to give them a go.
thanks -john
[1]: [ 19.846857] msm_dsi_phy ae94400.dsi-phy: [drm:dsi_pll_10nm_vco_prepare] *ERROR* DSI PLL(0) lock failed, status=0x00000000 [ 19.857925] msm_dsi_phy ae94400.dsi-phy: [drm:dsi_pll_10nm_vco_prepare] *ERROR* PLL(0) lock failed [ 19.866978] dsi_link_clk_enable_6g: Failed to enable dsi byte clk [ 19.873124] msm_dsi_host_power_on: failed to enable link clocks. ret=-110 [ 19.879987] dsi_mgr_bridge_pre_enable: power on host 0 failed, -110 [ 19.886309] Turning OFF PHY while PLL is on [ 20.415019] lt9611 10-003b: video check: hactive_a=0, hactive_b=0, vactive=0, v_total=0, h_total_sysclk=0 [ 20.481062] [drm:dpu_encoder_phys_vid_wait_for_commit_done:528] [dpu error]vblank timeout [ 20.489306] [drm:dpu_kms_wait_for_commit_done:453] [dpu error]wait for commit done returned -110 [ 20.513031] [drm:dpu_encoder_frame_done_timeout:2161] [dpu error]enc31 frame done timeout [ 20.553059] [drm:dpu_encoder_phys_vid_wait_for_commit_done:528] [dpu error]vblank timeout [ 20.561300] [drm:dpu_kms_wait_for_commit_done:453] [dpu error]wait for commit done returned -110 [ 20.625054] [drm:dpu_encoder_phys_vid_wait_for_commit_done:528] [dpu error]vblank timeout [ 20.633299] [drm:dpu_kms_wait_for_commit_done:453] [dpu error]wait for commit done returned -110 [ 20.657033] [drm:dpu_encoder_frame_done_timeout:2161] [dpu error]enc31 frame done timeout [ 20.697065] [drm:dpu_encoder_phys_vid_wait_for_commit_done:528] [dpu error]vblank timeout [ 20.705316] [drm:dpu_kms_wait_for_commit_done:453] [dpu error]wait for commit done returned -110 [ 20.769066] [drm:dpu_encoder_phys_vid_wait_for_commit_done:528] [dpu error]vblank timeout [ 20.777330] [drm:dpu_kms_wait_for_commit_done:453] [dpu error]wait for commit done returned -110 [ 20.801035] [drm:dpu_encoder_frame_done_timeout:2161] [dpu error]enc31 frame done timeout [ 20.845049] [drm:dpu_encoder_phys_vid_wait_for_commit_done:528] [dpu error]vblank timeout ...