Re: [PATCH v2] drm: shmobile: Reduce include dependencies

On Wed, Feb 05, 2020 at 07:33:22PM +0200, Laurent Pinchart wrote:

Hi Andy,

Thank you for the patch.

On Wed, Feb 05, 2020 at 11:32:26AM +0200, Andy Shevchenko wrote:

...

This file doesn't need everything provided by <linux/kernel.h>. All it needs are some types, which are provided by <linux/types.h>.

Note, <drm/drm_mode.h> already includes <linux/types.h>, but not relying on implicit includes is indeed a good thing.

Do we even need linux/types.h ? Apart from struct drm_mode_modeinfo, shmob_drm.h seems to only contain plain C without using any externally defined types.

Good point. It doesn't contain neither bool nor uXX or alike types. Probably we may simple drop the inclusion. I'll send v3.