于 2020年3月20日 GMT+08:00 下午5:11:22, Linus Walleij linus.walleij@linaro.org 写到:
On Fri, Mar 20, 2020 at 9:07 AM Icenowy Zheng icenowy@aosc.io wrote:
于 2020年3月19日 GMT+08:00 下午10:14:27, Linus Walleij
On Mon, Mar 16, 2020 at 2:37 PM Icenowy Zheng icenowy@aosc.io
wrote:
As noticed in the review of the driver, this display is very close
to
himax,hx8363.
I think the best is to determin what actual display controller it
is,
I think it is some kind of Ilitek controller since Ilitek ili9342 is clearly very similar.
It's Sitronix ST7703, same as the Librem 5 panel.
Heh, I wonder how it comes that it is so similar to Ilitek. I guess I will never understand how the silicon ecosystem works in asia (I did read a lot of Bunnie Huang's articles and hardware hacking book to try to understand...)
This file should be named sitronix,st7703.yaml then.
According to the code in the Librem 5: https://source.puri.sm/Librem5/linux-next/blob/imx8-current-librem5/drivers/... The actual name of the display is Techstar ts8550b.
Sorry, for Librem 5 panel, I mean Rocktech JH057N00900 here.
This is also the code that my patchset based on.
And the display controller is st7701, so maybe we should actually name it sitronix,st770x.yaml if there are some sub-variants of st770x?
properties: compatible: items: - const: xingbangda,xbd599 - const: ilitek,ili9342
Possibly use oneOf and add support for the himax,hx8363 already while you're at it.
This should at least be:
compatible: items: - enum: - xingbangda,xbd599 - himax,hx8363 - techstar,ts8550b - enum: - sitronix,st7701 - sitronix,st7703
So panel nodes using this panel become compatible = "xingbangda,sbd599", "sitronix,st7703" etc.
This way it is straight-forward for drivers to identify the panel vendor and display controller.
Yours, Linus Walleij
linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel