On Mon, Apr 28, 2014 at 11:10 AM, Ben Skeggs skeggsb@gmail.com wrote:
On Fri, Apr 25, 2014 at 5:19 PM, Alexandre Courbot acourbot@nvidia.com wrote:
nvc0_graph_ctor() would only let the graphics engine be enabled if its oclass has a proper microcode linked to it. This prevents GR from being enabled at all on chips that rely exclusively on external firmware, even though such a use-case is valid.
Relax the conditions enabling the GR engine to also include the case where an external firmware has also been loaded.
I'm happy to take this patch as-is. I do wonder if we should do something like this though:
if (nouveau_boolopt(device->cfgopt, "NvGrUseFW", oclass->fecs.ucode == NULL))
Which will automatically switch to external firmware if there's no internal implementation available.
Thoughts? This could be a separate patch even, if preferred.
Sure, that should work. Do you mind if I come with a follow-up patch for this so I don't have to re-sent the current patch series? Since this is the only comment it received so far.
Thanks, Alex.