Let's drop this patch. Mesa will use family_id.
Marek
On Wed, Sep 18, 2019 at 4:10 PM Marek Olšák maraeo@gmail.com wrote:
On Wed, Sep 18, 2019 at 10:03 AM Michel Dänzer michel@daenzer.net wrote:
On 2019-09-18 1:41 a.m., Marek Olšák wrote:
drmVersion::name = amdgpu, radeon, intel, etc. drmVersion::desc = vega10, vega12, vega20, ...
The common Mesa code will use name and desc to select the driver.
Like the Xorg modesetting driver, that code doesn't need this kernel functionality or new PCI IDs. It can just select the current driver for all devices which aren't supported by older drivers (which is a fixed set at this point).
The AMD-specific Mesa code will use desc to identify the chip.
Doesn't libdrm_amdgpu's struct amdgpu_gpu_info::family_id provide the same information?
Not for the common code, though I guess common Mesa code could use the INFO ioctl. Is that what you mean?
Marek