Hi Matt,
On Mon, Dec 13, 2021 at 10:16:47AM -0800, Matt Roper wrote:
On Sun, Dec 12, 2021 at 05:21:17PM +0200, Andi Shyti wrote:
GGTT was available both through i915->ggtt and gt->ggtt, and we eventually want to get rid of the i915->ggtt one. Move the GGTT from i915 to gt and use to_gt() for accesssing the ggtt.
Signed-off-by: Andi Shyti andi.shyti@linux.intel.com Cc: Michal Wajdeczko michal.wajdeczko@intel.com Cc: Matt Roper matthew.d.roper@intel.com
...
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_types.h b/drivers/gpu/drm/i915/gt/intel_gt_types.h index 14216cc471b1..02fc7641b82e 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt_types.h +++ b/drivers/gpu/drm/i915/gt/intel_gt_types.h @@ -69,7 +69,7 @@ enum intel_submission_method { struct intel_gt { struct drm_i915_private *i915; struct intel_uncore *uncore;
- struct i915_ggtt *ggtt;
struct i915_ggtt ggtt;
struct intel_uc uc;
I'm not sure this is the direction we want to go. Although it works for the initial multi-tile support, there's some other stuff coming up soon that will require two intel_gt's to share the same ggtt rather than each having an independent one.
Sure... I sent this just to have an opinion, I'm dropping it.
Thanks, Andi