Hi PAul,
On Sat, Aug 28, 2021 at 12:26:39PM +0100, Paul Cercueil wrote:
Add binding for the AUO A030JTN01 panel, which is a 320x480 3.0" 4:3 24-bit TFT LCD panel with non-square pixels and a delta-RGB 8-bit interface.
Signed-off-by: Paul Cercueil paul@crapouillou.net
.../bindings/display/panel/auo,a030jtn01.yaml | 57 +++++++++++++++++++ 1 file changed, 57 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/auo,a030jtn01.yaml
diff --git a/Documentation/devicetree/bindings/display/panel/auo,a030jtn01.yaml b/Documentation/devicetree/bindings/display/panel/auo,a030jtn01.yaml new file mode 100644 index 000000000000..21c9d62e3625 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/auo,a030jtn01.yaml @@ -0,0 +1,57 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/auo,a030jtn01.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: AUO A030JTN01 3.0" (320x480 pixels) 24-bit TFT LCD
+description: |
- The panel must obey the rules for a SPI slave device as specified in
- spi/spi-controller.yaml
+maintainers:
- Paul Cercueil paul@crapouillou.net
+allOf:
- $ref: panel-common.yaml#
+properties:
- compatible:
- const: auo,a030jtn01
- backlight: true
- port: true
- power-supply: true
- reg: true
- reset-gpios: true
+required:
- compatible
- reg
- power-supply
- reset-gpios
+unevaluatedProperties: false
+examples:
- |
- #include <dt-bindings/gpio/gpio.h>
As this is a spi slave, then it is supposed to be a node below a spi node. Other bindings add: spi { #address-cells = <1>; #size-cells = <0>; ... }
to make this obvious.
- panel@0 {
compatible = "auo,a030jtn01";reg = <0>;spi-max-frequency = <10000000>;reset-gpios = <&gpe 4 GPIO_ACTIVE_LOW>;power-supply = <&lcd_power>;backlight = <&backlight>;port {panel_input: endpoint {remote-endpoint = <&panel_output>;};};- };
My personal preference is indent with 4 spaces in the example - but there is no hard rules so 2 spaces is also fine.
With or without my nits above: Reviewed-by: Sam Ravnborg sam@ravnborg.org
Sam