Hi Douglas,
On Mon, Feb 07, 2022 at 02:34:34PM -0800, Doug Anderson wrote:
Hi,
On Sun, Feb 6, 2022 at 7:44 AM Sam Ravnborg sam@ravnborg.org wrote:
From: Rob Clark robdclark@chromium.org
Slightly awkward to fish out the display_info when we aren't creating own connector. But I don't see an obvious better way.
v3:
- Rebased and dropped the ti_sn_bridge_get_bpp() patch as this was solved in a different way (Sam)
v2:
- Remove error return with NO_CONNECTOR flag (Rob)
Signed-off-by: Rob Clark robdclark@chromium.org Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Rob Clark robdclark@chromium.org Cc: Douglas Anderson dianders@chromium.org Cc: Andrzej Hajda a.hajda@samsung.com Cc: Neil Armstrong narmstrong@baylibre.com Cc: Robert Foss robert.foss@linaro.org Cc: Laurent Pinchart Laurent.pinchart@ideasonboard.com Cc: Jonas Karlman jonas@kwiboo.se Cc: Jernej Skrabec jernej.skrabec@gmail.com
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-)
This is fine by me assuming we can fix the previous patches.
Reviewed-by: Douglas Anderson dianders@chromium.org
NOTE: to me, this isn't something to do _instead_ of my patch [1] but _in addition_ to it. ${SUBJECT} patch transitions us to a more modern approach of having the connector created elsewhere but doesn't remove the old fallback code. Might as well clean the fallback code up unless you think it's going to simply be deleted right away or something?
Until we know all users have NO_CONNECTOR support we need the connector creation code. Please just go ahead with your patches as you already got r-b from Laurent. For the debugfs patch I will look at it soonish unless someone beats me.
Sam
[1] https://lore.kernel.org/r/20220204161245.v2.1.I3ab26b7f197cc56c874246a43e579...