Re: [PATCH v2 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

• /*
  

•  * dma_sync_sg_*() flush the physical pages, so point
  

•  * sg->dma_address to the physical ones for the right behavior.
  

•  */
  

• for_each_sg(msm_obj->sgt->sgl, s, msm_obj->sgt->nents, i)
  

• 	sg_dma_address(s) = sg_phys(s);
  

I'm sorry, but this is completely bogus and not acceptable.

The only place that is allowed to initialize sg_dma_address is dma_map_sg. If the default dma ops don't work for your setup we have major a problem and need to fix the dma api / iommu integration instead of hacking around it.