Re: [PATCH 7/7] ARM: bcm2835: Add VC4 to the device tree.

On 08/12/2015 06:56 PM, Eric Anholt wrote:

Signed-off-by: Eric Anholt eric@anholt.net

Patch description?

diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi

arm-pmu {
	compatible = "arm,arm1176-pmu";
};

• hdmi: brcm,vc4-hdmi@7e902000 {
  

It'd be nice to keep all the DT nodes with a reg property together, and sorted in reg order.

As before, I think any DT node for a HW block that may-or-may-not-be used based on board connectivity/features should be disabled in the SoC .dtsi file, and enabled in the board's DT file if the feature is useful for that board.