On Fri, 18 Mar 2011 18:13:11 -0500 (CDT) Ilija Hadzic ihadzic@research.bell-labs.com wrote:
On Fri, 18 Mar 2011, Jesse Barnes wrote:
I like the new param check, but I'd still prefer a new ioctl to abusing the old one.
It's not "abusing" it but extending the interface in a backwards-compatible manner. Introducing a new one would result in two ioctls that essentially do the same thing, which I don't like.
Yes abusing was a strong word; I just don't like encoding crtc numbers in a bitfield, when we just use ints everywhere else.
Not a big deal, Dave will make the final call. Thanks for doing this work.