Re: [PATCH 3/4] drm/tilcdc: add encoder slave

On Tue, Jan 22, 2013 at 04:36:24PM -0600, Rob Clark wrote:

Add output panel driver for i2c encoder slaves.

Signed-off-by: Rob Clark robdclark@gmail.com

Found some more stuff ...

[cut]

+static const struct drm_encoder_helper_funcs slave_encoder_helper_funcs = {

• .dpms           = drm_i2c_encoder_dpms,
  

• .mode_fixup     = drm_i2c_encoder_mode_fixup,
  

• .prepare        = slave_encoder_prepare,
  

• .commit         = drm_i2c_encoder_commit,
  

• .mode_set       = drm_i2c_encoder_mode_set,
  

• .save           = drm_i2c_encoder_save,
  

• .restore        = drm_i2c_encoder_restore,
  

+};

I couldn't find these wrappers anywhere ...

+static const struct i2c_board_info info = {

• I2C_BOARD_INFO("tda998x", 0x70)
  

+};

Shouldn't there be some of/devicetree thing to tell us which one to load? -Daniel