On Thu, Aug 13, 2020 at 3:04 AM Brian Starkey brian.starkey@arm.com wrote:
On Sat, Jul 25, 2020 at 03:26:33AM +0000, John Stultz wrote:
Add proper refcounting on the dma_heap structure. While existing heaps are built-in, we may eventually have heaps loaded from modules, and we'll need to be able to properly handle the references to the heaps
I'm not 100% clear on the intention here. What would take/drop a reference on a heap?
Yea. At the moment nothing, but I did this cleanup as part of some other changes which would allow drivers that want to produce a dmabuf without having to create their own exporter to find an existing heap and allocate from that. Thus we needed to do proper reference counting on the handles to the heap. Those changes are stuck for now waiting for an user to be publicly submitted, but this change initially seemed like a reasonable correctness cleanup, so I went ahead and sent it, but as Daniel noted we can wait for real users to be submitted before adding any extra complexity upstream.
In the case of modules I think the bigger problem is how to prevent the module getting removed while there's still something using it.
That's true. Probably need something like a kref on each buffer allocated.
thanks -john