They're not how system suspend/resume should be done with atomic (there's new helpers for that developed by Thierry Redding), and for legacy drivers this really should be a helper hook and not a core one.
But there's not even helper code to use them, and only 2 drivers (which now have their own private hooks) set them. Ditch them.
Saves me typing some kerneldoc, too ;-)
Signed-off-by: Daniel Vetter daniel.vetter@intel.com --- include/drm/drm_crtc.h | 11 ----------- 1 file changed, 11 deletions(-)
diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 340d750f1364..6c92da82f8c5 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -320,8 +320,6 @@ struct drm_crtc_state {
/** * struct drm_crtc_funcs - control CRTCs for a given device - * @save: save CRTC state - * @restore: restore CRTC state * @cursor_set: setup the cursor * @cursor_set2: setup the cursor with hotspot, superseeds @cursor_set if set * @cursor_move: move the cursor @@ -339,11 +337,6 @@ struct drm_crtc_state { * bus accessors. */ struct drm_crtc_funcs { - /* Save CRTC state */ - void (*save)(struct drm_crtc *crtc); /* suspend? */ - /* Restore CRTC state */ - void (*restore)(struct drm_crtc *crtc); /* resume? */ - /** * @reset: * @@ -626,8 +619,6 @@ struct drm_connector_state { /** * struct drm_connector_funcs - control connectors on a given device * @dpms: set power state - * @save: save connector state - * @restore: restore connector state * @detect: is this connector active? * @fill_modes: fill mode list for this connector * @force: notify the driver that the connector is forced on @@ -638,8 +629,6 @@ struct drm_connector_state { */ struct drm_connector_funcs { int (*dpms)(struct drm_connector *connector, int mode); - void (*save)(struct drm_connector *connector); - void (*restore)(struct drm_connector *connector);
/** * @reset: