Am 28.11.20 um 23:40 schrieb Sam Ravnborg:
The tmp variable were assigned but the result was never used,
s/were/was
so delete the tmp variable.
v2:
- Update subject (Lee)
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: "Gustavo A. R. Silva" gustavoars@kernel.org Cc: Sam Ravnborg sam@ravnborg.org Cc: Jani Nikula jani.nikula@intel.com Cc: Daniel Vetter daniel.vetter@ffwll.ch Cc: Arnd Bergmann arnd@arndb.de Cc: Lee Jones lee.jones@linaro.org
Acked-by: Thomas Zimmermann tzimmermann@suse.de
drivers/video/fbdev/tdfxfb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c index f056d80f6359..67e37a62b07c 100644 --- a/drivers/video/fbdev/tdfxfb.c +++ b/drivers/video/fbdev/tdfxfb.c @@ -206,9 +206,7 @@ static inline u8 crt_inb(struct tdfx_par *par, u32 idx)
static inline void att_outb(struct tdfx_par *par, u32 idx, u8 val) {
- unsigned char tmp;
- tmp = vga_inb(par, IS1_R);
- vga_inb(par, IS1_R);
It resets the attribute register's state. Hopefully, this doesn't get optimized away.
vga_outb(par, ATT_IW, idx); vga_outb(par, ATT_IW, val); }