Quoting Dmitry Baryshkov (2022-01-31 18:34:47)
On 27/01/2022 02:46, Kuogee Hsieh wrote:
DP driver is a generic driver which supports both eDP and DP. For debugging purpose it is required to have capabilities to differentiate message are generated from eDP or DP. This patch do:
- add connector type into debug messages within dp_display.c
- revise debug messages related to DP phy within dp_ctrl.c
- replace DRM_DEBUG_DP marco with drm_dbg_dp
You list three items here. This patch should be split into respective three parts.
Changes in V2: -- replace DRM_DEBUG_DP marco with drm_dbg_dp
I suppose that Stephen's idea was to pass proper drm_device to this function rather than always passing NULL.
The idea was to pass 'struct something' and then have a 'dev' named member inside that's a struct device.
struct something { struct device *dev; ... };
Then the macro will extract the device out of it and use it to print messages. It may be an abuse of the macro though because initially I thought it needed to be a drm device but that doesn't seem to be the case?