Comment # 12 on bug 89785 from
Comment on attachment 114780 [details] [review]
Fix for bug described in commet 4

Review of attachment 114780 [details] [review]:
-----------------------------------------------------------------

I think it would be better if SI_KILL could be fixed not to clobber VCC in the
first place, e.g. by using the 64-bit encoding of the v_cmp(x)_lt_f32[0]
instruction. But failing that, this looks good.

[0] BTW, it's currently using v_cmpx_le_f32, but I think that's incorrect, as
the comment says "Clear this thread from the exec mask if the operand is
negative".


You are receiving this mail because: