Re: [PATCH v4 1/1] drm/syncobj: add sideband payload

Quoting Chris Wilson (2019-08-09 12:58:51)

Quoting Lionel Landwerlin (2019-08-09 12:30:30)

...

•           if (flags & I915_DRM_SYNCOBJ_BINARY_ITEM_VALUE_READ) {
  

•                   copy_to_user(&values[i], &syncobjs[i]->binary_payload, sizeof(values[i]));
  

•                   ret = ret ? -EFAULT : 0;
  

More magic.

if (put_user(&syncobjs[i]->binary_payload, &values[i])) return -EFAULT;

(break not yet)

Should just be put_user(syncobjs[i]->binary_payload, &values[i]) The value of, not its address. -Chris