Hi Laurent,
On Tue, Feb 25, 2020 at 01:37:08AM +0200, Laurent Pinchart wrote:
Hi Sebastian,
Thank you for the patch.
Thanks for the review.
On Tue, Feb 25, 2020 at 12:20:32AM +0100, Sebastian Reichel wrote:
Add Droid 4 specific compatible value in addition to the generic one, so that we have the ability to add panel specific quirks in the future.
We need to document this compatible string in DT bindings, I don't think this is included in this series.
Correct, right now none of the extra compatible strings are documented in the binding file. E.g. "tpo,taal" is used by omap4-sdp and in the example section of the DT bindings.
Furthermore, could we use a compatible string that actually matches the panel vendor and model, instead of the device name ?
We don't know the Droid 4 panel vendor and/or model. For N950 "nokia,himalaya" is used, which is obviously also not the real vendor. But for N950 there is a good reason to use a N950 specific compatible anyways, since some pixels are covered by plastic.
Maybe this can just be handled when the bindings file is converted to YAML?
-- Sebastian
Signed-off-by: Sebastian Reichel sebastian.reichel@collabora.com
arch/arm/boot/dts/motorola-mapphone-common.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/motorola-mapphone-common.dtsi b/arch/arm/boot/dts/motorola-mapphone-common.dtsi index a5e4ba7c8dab..622383ec6a75 100644 --- a/arch/arm/boot/dts/motorola-mapphone-common.dtsi +++ b/arch/arm/boot/dts/motorola-mapphone-common.dtsi @@ -200,7 +200,7 @@ dsi1_out_ep: endpoint { };
lcd0: panel@0 {
compatible = "panel-dsi-cm";
compatible = "motorola,droid4-panel", "panel-dsi-cm";-- Regards,
Laurent Pinchart