Re: [PATCH v3 5/7] drm/mediatek: mtk_dsi: Use simple encoder

Hi, Enric:

Enric Balletbo i Serra enric.balletbo@collabora.com 於 2020年4月17日 週五 下午11:06寫道：

The mtk_dsi driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder.

Reviewed-by: Chun-Kuang Hu chunkuang.hu@kernel.org

Signed-off-by: Enric Balletbo i Serra enric.balletbo@collabora.com Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com

---

Changes in v3: None Changes in v2: None

drivers/gpu/drm/mediatek/mtk_dsi.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index 869ae0a2e9f8..d68694ff00dc 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -22,6 +22,7 @@ #include <drm/drm_panel.h> #include <drm/drm_print.h> #include <drm/drm_probe_helper.h> +#include <drm/drm_simple_kms_helper.h>

#include "mtk_drm_ddp_comp.h"

@@ -788,15 +789,6 @@ static void mtk_output_dsi_disable(struct mtk_dsi *dsi) dsi->enabled = false; }

-static void mtk_dsi_encoder_destroy(struct drm_encoder *encoder) -{

•   drm_encoder_cleanup(encoder);
  

-}

-static const struct drm_encoder_funcs mtk_dsi_encoder_funcs = {

•   .destroy = mtk_dsi_encoder_destroy,
  

-};

static int mtk_dsi_create_conn_enc(struct drm_device *drm, struct mtk_dsi *dsi); static void mtk_dsi_destroy_conn_enc(struct mtk_dsi *dsi);

@@ -1140,8 +1132,8 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi) { int ret;

•   ret = drm_encoder_init(drm, &dsi->encoder, &mtk_dsi_encoder_funcs,
  

•                          DRM_MODE_ENCODER_DSI, NULL);
  

•   ret = drm_simple_encoder_init(drm, &dsi->encoder,
  

•                                 DRM_MODE_ENCODER_DSI);
    if (ret) {
            DRM_ERROR("Failed to encoder init to drm\n");
            return ret;
  

-- 2.25.1