1 Aug
2012
1 Aug
'12
9:13 a.m.
On 31 July 2012 17:39, Eric Anholt eric@anholt.net wrote:
Daniel Martin consume.noise@gmail.com writes:
Add a configure option --with/--without-valgrind to be able to compile libdrm with or without valgrind. The latter was not possible if pkgconfig found the valgrind package.
How would you have the valgrind .pc file but be unable to build with valgrind? .pc files should come with the parts necessary to build.
It was a bug in our build system, which didn't exported the include path correctly.
But, regardless of this homebrewn bug. I like to leave decissions up to the user: If it is possible to build without valgrind - make it an option. The same goes for the tests. Where I would like to create a patch too.