Re: [Intel-gfx] [PATCH 03/19] drm/i915: Remove pointless planes_changed=true assignment

On Mon, 2019-07-08 at 15:53 +0300, Ville Syrjala wrote:

From: Ville Syrjälä ville.syrjala@linux.intel.com

i915 doesn't use the crtc_state->plane_changed flag for anything, so setting it is pointless.

Signed-off-by: Ville Syrjälä ville.syrjala@linux.intel.com

drivers/gpu/drm/i915/display/intel_atomic.c | 7 ------- 1 file changed, 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_atomic.c b/drivers/gpu/drm/i915/display/intel_atomic.c index 90ca11a4ae88..954d4a930864 100644 --- a/drivers/gpu/drm/i915/display/intel_atomic.c +++ b/drivers/gpu/drm/i915/display/intel_atomic.c @@ -378,13 +378,6 @@ int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv, plane->base.id); return PTR_ERR(state); }

• 		/*
  

• 		 * the plane is added after plane
  

checks are run,

• 		 * but since this plane is unchanged
  

just do the

• 		 * minimum required validation.
  

• 		 */
  

• 		crtc_state->base.planes_changed = true;
  }
  
  intel_plane = to_intel_plane(plane);
  

Reviewed-by: Stanislav Lisovskiy stanislav.lisovskiy@intel.com