on_each_cpu always returns a hard coded return code of zero.
Removing all tests based on this return value saves run time cycles for compares and code bloat for branches.
CC: Michal Nazarewicz mina86@mina86.com CC: David Airlie airlied@linux.ie CC: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/drm_cache.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c index 5928653..668653c 100644 --- a/drivers/gpu/drm/drm_cache.c +++ b/drivers/gpu/drm/drm_cache.c @@ -75,8 +75,7 @@ drm_clflush_pages(struct page *pages[], unsigned long num_pages) return; }
- if (on_each_cpu(drm_clflush_ipi_handler, NULL, 1) != 0) - printk(KERN_ERR "Timed out waiting for cache flush.\n"); + on_each_cpu(drm_clflush_ipi_handler, NULL, 1);
#elif defined(__powerpc__) unsigned long i;