On Tue, 18 Oct 2016, "Sharma, Shashank" shashank.sharma@intel.com wrote:
Reviewed-by: Shashank Sharma
Both pushed to drm-intel-next-queued, thanks for the review.
RB, Jani.
Regards Shashank -----Original Message----- From: Nikula, Jani Sent: Tuesday, October 18, 2016 4:52 PM To: intel-gfx@lists.freedesktop.org Cc: Nikula, Jani jani.nikula@intel.com; Vivi, Rodrigo rodrigo.vivi@intel.com; Sharma, Shashank shashank.sharma@intel.com; dri-devel@lists.freedesktop.org Subject: [PATCH 1/2] drm: make is_lspcon_adaptor static
Fixes sparse warning:
drivers/gpu/drm/drm_dp_dual_mode_helper.c:151:6: warning: symbol 'is_lspcon_adaptor' was not declared. Should it be static?
Fixes: 056996b95686 ("drm: Helper for lspcon in drm_dp_dual_mode") Cc: Rodrigo Vivi rodrigo.vivi@intel.com Cc: Shashank Sharma shashank.sharma@intel.com Cc: dri-devel@lists.freedesktop.org Signed-off-by: Jani Nikula jani.nikula@intel.com
n.b. 056996b95686 ("drm: Helper for lspcon in drm_dp_dual_mode") has been merged via drm-intel tree
drivers/gpu/drm/drm_dp_dual_mode_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_dp_dual_mode_helper.c b/drivers/gpu/drm/drm_dp_dual_mode_helper.c index a7aeb1ec852c..2624e266abbd 100644 --- a/drivers/gpu/drm/drm_dp_dual_mode_helper.c +++ b/drivers/gpu/drm/drm_dp_dual_mode_helper.c @@ -148,8 +148,8 @@ static bool is_type2_adaptor(uint8_t adaptor_id) DP_DUAL_MODE_REV_TYPE2); }
-bool is_lspcon_adaptor(const char hdmi_id[DP_DUAL_MODE_HDMI_ID_LEN],
- const uint8_t adaptor_id)
+static bool is_lspcon_adaptor(const char hdmi_id[DP_DUAL_MODE_HDMI_ID_LEN],
const uint8_t adaptor_id){ return is_hdmi_adaptor(hdmi_id) && (adaptor_id == (DP_DUAL_MODE_TYPE_TYPE2 | -- 2.1.4