On Tue, Feb 4, 2020 at 9:42 AM Jordan Crouse jcrouse@codeaurora.org wrote:
Commit e812744c5f95 ("drm: msm: a6xx: Add support for A618") added a universal GBIF un-halt into a6xx_start(). This can cause problems for a630 targets which do not use GBIF and might have access protection enabled on the region now occupied by the GBIF registers.
But it turns out that we didn't need to unhalt the GBIF in this path since the stop function already takes care of that after executing a flush but before turning off the headswitch. We should be confident that the GBIF is open for business when we restart the hardware.
Signed-off-by: Jordan Crouse jcrouse@codeaurora.org
Sorry, yesterday got busy with other things and I didn't get around to testing your patch, but I have tested earlier with my own patch which is identical: https://git.linaro.org/people/john.stultz/android-dev.git/commit/?h=dev/db84...
So, I think I can safely add: Tested-by: John Stultz john.stultz@linaro.org
Thanks so much for the quick turnaround on this! -john