On Wed, Jun 23, 2010 at 07:06:22PM +0200, Dan Carpenter wrote:
We don't need to check the list cursor in a list_for_each_entry(). It's always non-null.
Here is another one that never got applied. I has a sad face. :(
regards, dan carpenter
Signed-off-by: Dan Carpenter error27@gmail.com
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index cc8131f..8a2bdfc 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -745,7 +745,7 @@ bool intel_pipe_has_type (struct drm_crtc *crtc, int type) struct drm_encoder *l_entry;
list_for_each_entry(l_entry, &mode_config->encoder_list, head) {
if (l_entry && l_entry->crtc == crtc) {
if (l_entry->crtc == crtc) { struct intel_encoder *intel_encoder = enc_to_intel_encoder(l_entry); if (intel_encoder->type == type) return true;@@ -3322,7 +3322,7 @@ static int intel_crtc_mode_set(struct drm_crtc *crtc,
list_for_each_entry(encoder, &mode_config->encoder_list, head) {
if (!encoder || encoder->crtc != crtc)
if (encoder->crtc != crtc) continue;intel_encoder = enc_to_intel_encoder(encoder);