Re: [PATCH 2/4] drm/format-helper: Remove optional byte-swap from line convertion

Hello Thomas,

On 4/27/22 16:14, Thomas Zimmermann wrote:

Implement per-pixel byte swapping in a separate conversion helper for the single function that requires it. Select the correct helper for each conversion.

Signed-off-by: Thomas Zimmermann tzimmermann@suse.de

Reviewed-by: Javier Martinez Canillas javierm@redhat.com

I couldn't spot any issues but I believe these conversion helpers are not easy to read and one could miss subtle issues so it would be nice to have unit tests for these using the KUnit infrastructure:

https://www.kernel.org/doc/html/latest/dev-tools/kunit/index.html

I'm not asking to do it as a part of this series but something that we may do as a follow-up though, just mentioning.

I'll post a patch to add that task to Documentation/gpu/todo.rst, so it is tracked somewhere.