Re: [PATCH 4/4] drm/virtio: move virtio_gpu_mem_entry initialization to new function

On Thu, Feb 6, 2020 at 12:55 AM Gerd Hoffmann kraxel@redhat.com wrote:

Hi,

...

...

    virtio_gpu_cmd_resource_attach_backing(vgdev, obj->hw_res_handle,

•                                          ents, nents,
  

•                                          obj->ents, obj->nents,
                                           fence);
  

•   obj->ents = NULL;
  

•   obj->nents = 0;
  

Hm, if the entries are temporary, can we allocate and initialize them in this function?

Well, the plan for CREATE_RESOURCE_BLOB is to use obj->ents too ...

Is obj->ents needed after CREATE_RESOURCE_BLOB? If not, having yet another helper

ents = virtio_gpu_object_alloc_mem_entries(..., &count);

seems cleaner. We would also be able to get rid of virtio_gpu_object_attach.

cheers, Gerd