Hi,
On Tue, 23 Feb 2021 at 14:27, Daniel Stone daniel@fooishbar.org wrote:
Bumping this one: it seems like the Rockchip VOP either always applies the YTR transform, or has a YTR control bit which is not documented in the driver's register definitions. This means that it is incorrect to advertise the currently-used modifier, which specifies that YTR is _not_ used, and doing so breaks Panfrost which correctly uses the modifier as documented. Based on our knowledge of Mali, we believe that Panfrost is correct, and the error lies with Rockchip erroneously using the YTR transform in the VOP's AFBC decoder despite declaring through the modifier that YTR is not in use.
Looking at the downstream vendor tree, VOP2 as used in newer SoCs has explicit control bits for YTR and other AFBC knobs, but this has been substantially reworked from the original VOP and is not applicable to this IP block.
Mark, or others from Rockchip, can you please:
Sorry, I meant Sandy rather than Mark! Old habits die hard.
Anyway, this patch itself is: Acked-by: Daniel Stone daniels@collabora.com
Cheers, Daniel