Re: [PATCH v2 55/63] HID: roccat: Use struct_group() to zero kone_mouse_event

On Fri, Aug 20, 2021, 6:02 AM Jiri Kosina jikos@kernel.org wrote:

On Tue, 17 Aug 2021, Kees Cook wrote:

...

In preparation for FORTIFY_SOURCE performing compile-time and run-time field bounds checking for memset(), avoid intentionally writing across neighboring fields.

Add struct_group() to mark region of struct kone_mouse_event that should be initialized to zero.

Cc: Stefan Achatz erazor_de@users.sourceforge.net Cc: Jiri Kosina jikos@kernel.org Cc: Benjamin Tissoires benjamin.tissoires@redhat.com Cc: linux-input@vger.kernel.org Signed-off-by: Kees Cook keescook@chromium.org

Applied, thank you Kees.

Eek! No, this will break the build: struct_group() is not yet in the tree. I can carry this with an Ack, etc.

-Kees